Comments on: Animated Scrolling in jQuery http://robinadr.com/2007/10/animated_scrolling_in_jquery big pimpin' Wed, 18 Aug 2010 06:30:29 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Karl Swedberg http://robinadr.com/2007/10/animated_scrolling_in_jquery/comment-page-1#comment-141 Karl Swedberg Sun, 14 Oct 2007 22:52:40 +0000 http://robinadr.com/2007/10/animated_scrolling_in_jquery#comment-141 <p>Heh, no problem, Robin. I was wondering why the comment didn't show up, though. Cheers.</p> Heh, no problem, Robin. I was wondering why the comment didn’t show up, though. Cheers.

]]> By: Robin http://robinadr.com/2007/10/animated_scrolling_in_jquery/comment-page-1#comment-136 Robin Sun, 14 Oct 2007 17:25:47 +0000 http://robinadr.com/2007/10/animated_scrolling_in_jquery#comment-136 <p>Oh, and sorry about your comment getting marked as spam, Akismet seems to be a bit off lately.</p> Oh, and sorry about your comment getting marked as spam, Akismet seems to be a bit off lately.

]]> By: Robin http://robinadr.com/2007/10/animated_scrolling_in_jquery/comment-page-1#comment-135 Robin Sun, 14 Oct 2007 17:25:13 +0000 http://robinadr.com/2007/10/animated_scrolling_in_jquery#comment-135 <p>Interesting, because with the original code my external anchors wouldn't work -- nothing happened when I clicked them, but once I changed the selector to <code>[href^=#]</code> it worked fine.</p> <p>Probably my bad copying ;).</p> Interesting, because with the original code my external anchors wouldn’t work — nothing happened when I clicked them, but once I changed the selector to [href^=#] it worked fine.

Probably my bad copying ;).

]]> By: Karl Swedberg http://robinadr.com/2007/10/animated_scrolling_in_jquery/comment-page-1#comment-132 Karl Swedberg Sun, 14 Oct 2007 12:39:51 +0000 http://robinadr.com/2007/10/animated_scrolling_in_jquery#comment-132 <p>Hi there,</p> <p>Thanks for linking to my entry! Actually, though, I put that selector -- $('a[href*=#]') -- in there intentionally, to account for all possible ways that someone could link to an anchor on the same page. The next line in my script limits it to anchors on the <em>same</em> page with this <code>if</code> condition:</p> <p><code>if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname)</code></p> <p>Of course, if you know that you'll always begin your same-page <code>href</code>s with the hash, then your method is preferable, and that next condition is unnecessary. But I felt I should make mine as generic as possible to account for an weirdness that might result from a wysywig editor in a CMS or an inexperienced content person.</p> <p>The script does have another problem, though, which I'll be addressing in a follow-up entry soon.</p> Hi there,

Thanks for linking to my entry! Actually, though, I put that selector — $(‘a[href*=#]’) — in there intentionally, to account for all possible ways that someone could link to an anchor on the same page. The next line in my script limits it to anchors on the same page with this if condition:

if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname)

Of course, if you know that you’ll always begin your same-page hrefs with the hash, then your method is preferable, and that next condition is unnecessary. But I felt I should make mine as generic as possible to account for an weirdness that might result from a wysywig editor in a CMS or an inexperienced content person.

The script does have another problem, though, which I’ll be addressing in a follow-up entry soon.

]]> By: Matt http://robinadr.com/2007/10/animated_scrolling_in_jquery/comment-page-1#comment-130 Matt Sun, 14 Oct 2007 05:39:48 +0000 http://robinadr.com/2007/10/animated_scrolling_in_jquery#comment-130 <p>That's pretty sweet. The thing jQuery makes so easy, but would we so complicated without it... is amazing!</p> That’s pretty sweet. The thing jQuery makes so easy, but would we so complicated without it… is amazing!

]]>